[PATCH] ARM: imx: Add some core definitions for MX53
grant.likely at secretlab.ca
Wed Oct 27 06:22:53 EDT 2010
On Wed, Oct 27, 2010 at 11:09:21AM +0200, Uwe Kleine-König wrote:
> On Wed, Oct 27, 2010 at 09:29:59AM +0100, Grant Likely wrote:
> > > ---
> > > arch/arm/plat-mxc/include/mach/iomux-mx53.h | 301 +++++++++++++++++++
> > > arch/arm/plat-mxc/include/mach/mx53.h | 433 +++++++++++++++++++++++++++
> > Hi Dinh.
> > In general, these definitions should not be added until they are
> > actually needed by driver code.
> > Also, from my understanding, the mx53 is very similar to the mx51.
> > If I'm correct, then they should be sharing the same set of #defines.
> Note, I asked for a seperate header file. See
For the record, I disagree with that approach. The approach I would
take is for the imx53 code to use the imx51 defines by default, and to
only define imx53 variants where there are differences. Otherwise the
code to support imx53 has to be completely divergent from imx51
because the defines are different symbols.
More information about the linux-arm-kernel