[PATCH] MMC: add support for the Marvell platform SDHCI controller

Saeed Bishara saeed at marvell.com
Wed Oct 27 04:46:17 EDT 2010


 
 
>+config MMC_SDHCI_MV
>+	bool "SDHCI support on Marvell's SoC"
>+	depends on MMC_SDHCI
>+	depends on MMC_SDHCI_PLTFM
>+	select MMC_SDHCI_IO_ACCESSORS
>+	help
>+	  This selects the Secure Digital Host Controller Interface in
>+	  Marvell's SoC controllers.
>+
>+	  If you have a controller with this interface, say Y or M here.
>+
>+	  If unsure, say N.
>+
Mike, the config name and description is too generic as there are several sdhci controllers on Marvell devices (see like pxa), I suggest to name it SDHCI_DOVE and make it depends on ARCH_DOVE and modify the description accordingly.

>+#include <linux/clk.h>
>+#include <linux/delay.h>
>+#include <linux/err.h>
>+#include <linux/platform_device.h>
>+#include <linux/io.h>
>+#include <linux/mmc/host.h>
>+#include "sdhci.h"
>+#include "sdhci-pltfm.h"
are those includes are realy needed? At least the delay.h and clk.h not needed for now.

saeed


More information about the linux-arm-kernel mailing list