[PATCH] ARM: memblock: set allocation limit for MEMBLOCK_ALLOC_ANYWHERE

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Oct 26 15:30:16 EDT 2010


On Tue, Oct 26, 2010 at 07:08:43PM +0100, Will Deacon wrote:
> Russell,
> 
> On Tue, 2010-10-26 at 11:56 +0100, Russell King - ARM Linux wrote:
> > On Mon, Oct 25, 2010 at 11:55:36PM +0100, Will Deacon wrote:
> > > Right. I could also move this call out of sanity_check_meminfo
> > > and into arm_memblock_init now that we don't need lowmem_end_addr
> > > to be initialised. If you're happy with me making that change then
> > > I'll post a revised version to the patch system.
> > 
> > It looks like we're doing a few things out of order.  Yes, it makes
> > sense to move that initialization to arm_memblock_init(), but as we're
> > not running sanity_check_meminfo(), it could mean there's problems
> > with out of order membanks and similar.
> > 
> We could move the arm_memblock_init() call into paging_init, immediately
> after the call to sanity_check_meminfo. I think everything should be
> safe then.

Well, there's actually some things which the mmu-ful stuff does (such as
sorting) which the nommu stuff should also do for safety sake, so I
think a little bit of a cleanup in this area would be no bad thing,
rather than trying to move arm_memblock_init() into both the MMU and
noMMU code.



More information about the linux-arm-kernel mailing list