[PATCHv6 1/3] ARM: imx: Add gpio-keys to plat-mxc
u.kleine-koenig at pengutronix.de
Sun Oct 24 15:17:01 EDT 2010
On Sat, Oct 23, 2010 at 01:38:50PM +0200, Eric Bénard wrote:
> Hi Uwe,
> Le 23/10/2010 11:50, Uwe Kleine-König a écrit :
>> On Sat, Oct 23, 2010 at 10:06:21AM +0200, Eric Bénard wrote:
>>> Le 23/10/2010 04:46, Dinh.Nguyen at freescale.com a écrit :
>>>> +struct platform_device *__init imx_add_gpio_keys(
>>>> + const struct gpio_keys_platform_data *pdata)
>>>> + return imx_add_platform_device("gpio-keys", -1, NULL,
>>>> + 0, pdata, sizeof(*pdata));
>>> What is the added value of this ?
>> Is is (more or less) in line with the other imx functions that
>> dynamically add platform devices.
>>> gpio-keys is not i.MX specific so why should that land in plat-mxc ?
>> I consider it OK for now. I know Eric does/wants something similar for
>> pxa. If you want to push forward unification here that's great, but
>> IMHO this is nothing that should stop this patch which is a good step
> Does that mean that, for example, for cpuimx51 and cpuimx51sd boards, I
> should create : imx_add_gpio_leds, imx_add_serial_8250 and
> imx_add_i2c_gpio functions instead of creating the platform_device
> structure in the board's files and using platform_add_devices to register
> it ?
The added benefit is that if you (or someone else) do(es) they don't
occupy memory when a different machine is booted because the functions
and their input data can live in .init sections. I didn't measure the
impact on booting time, but I think it doesn't make much difference.
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel