[PATCH] dma/coh901318: fix copy_to_user error path

Arnd Bergmann arnd at arndb.de
Fri Oct 22 13:38:12 EDT 2010

On Friday 22 October 2010 19:29:53 Nicolas Kaiser wrote:
> If copy_to_user fails, the assigned error code instantly gets
> overwritten, and the failure apparently ignored. Moreover,
> shouldn't the error code be -EFAULT instead of -EINVAL?

Looks good, but it would be even better to just use
simple_read_from_buffer in this function, which takes care of
a lot the other complexities as well.


More information about the linux-arm-kernel mailing list