[PATCH V3 1/1]MMC: add support of sdhci-pxa driver

zhangfei gao zhangfei.gao at gmail.com
Fri Oct 22 10:09:03 EDT 2010


On Fri, Oct 22, 2010 at 7:04 AM, Chris Ball <cjb at laptop.org> wrote:
> Hi,
>
> On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote:
> [...]
>> +#ifdef CONFIG_PM
>> +static int sdhci_pxa_suspend(struct platform_device *dev)
>> +{
>> +     struct sdhci_host *host = platform_get_drvdata(to_platform_device(dev));
>> +
>> +     return sdhci_suspend_host(host, state);
>> +}
>> +
>> +static int sdhci_pxa_resume(struct platform_device *dev)
>> +{
>
> These prototypes are not correct, leading to:
>
>  CC [M]  drivers/mmc/host/sdhci-pxa.o
> drivers/mmc/host/sdhci-pxa.c: In function ‘sdhci_pxa_suspend’:
> drivers/mmc/host/sdhci-pxa.c:205: warning: initialization from incompatible pointer type
> drivers/mmc/host/sdhci-pxa.c:207: error: ‘state’ undeclared (first use in this function)
> drivers/mmc/host/sdhci-pxa.c:207: error: (Each undeclared identifier is reported only once
> drivers/mmc/host/sdhci-pxa.c:207: error: for each function it appears in.)
> drivers/mmc/host/sdhci-pxa.c: In function ‘sdhci_pxa_resume’:
> drivers/mmc/host/sdhci-pxa.c:212: warning: initialization from incompatible pointer type
> drivers/mmc/host/sdhci-pxa.c: At top level:
> drivers/mmc/host/sdhci-pxa.c:222: warning: initialization from incompatible pointer type
> drivers/mmc/host/sdhci-pxa.c:223: warning: initialization from incompatible pointer type
>
> when compiled with CONFIG_PM=y.
>
> --
> Chris Ball   <cjb at laptop.org>   <http://printf.net/>
> One Laptop Per Child
>

Sorry, forgot open CONFIG_PM.
Updated patch, thanks


More information about the linux-arm-kernel mailing list