[PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API

Sergei Shtylyov sshtylyov at mvista.com
Thu Oct 21 13:47:46 EDT 2010


Hello.

On 21-10-2010 12:04, Kukjin Kim wrote:

> From: Daein Moon<moon9124 at samsung.com>

> This patch adds the s3c_gpio_getpull() API that has been missed in the
> plat-samsung/gpio-config.c and actullay there is its extern declaration
> in plat/gpio-cfg.h.

> Signed-off-by: Daein Moon<moon9124 at samsung.com>
> Cc: Ben Dooks<ben-linux at fluff.org>
> Signed-off-by: Kukjin Kim<kgene.kim at samsung.com>
> ---
> NOTE:
> - already issued about this

>   arch/arm/plat-samsung/gpio-config.c                |   19 +++++++++++++++++++
>   .../plat-samsung/include/plat/gpio-cfg-helpers.h   |    6 ++++++
>   2 files changed, 25 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/plat-samsung/gpio-config.c b/arch/arm/plat-samsung/gpio-config.c
> index 8a37211..b732b77 100644
> --- a/arch/arm/plat-samsung/gpio-config.c
> +++ b/arch/arm/plat-samsung/gpio-config.c
[...]
> diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> index 3e21c75..c417f85 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> @@ -42,6 +42,12 @@ static inline int s3c_gpio_do_setpull(struct s3c_gpio_chip *chip,
>   	return (chip->config->set_pull)(chip, off, pull);
>   }
>
> +static inline unsigned s3c_gpio_do_getpull(struct s3c_gpio_chip *chip,
> +					   unsigned int off)
> +{
> +	return (chip->config->get_pull)(chip, off);

    Parens are not necessary here.

> +}
> +

WBR, Sergei



More information about the linux-arm-kernel mailing list