[PATCH v2 1/1] mx35pdk: add debug board support

Fabio Estevam festevam at gmail.com
Wed Oct 20 09:29:35 EDT 2010


On Wed, Oct 20, 2010 at 11:17 AM, Fabio Estevam <festevam at gmail.com> wrote:
> Xiao.
>
> On Wed, Oct 20, 2010 at 7:34 AM,  <jgq516 at gmail.com> wrote:
> ...
>>        mxc_register_device(&mxc_otg_udc_device, &usb_pdata);
>> +
>> +       if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT))
>> +               pr_warn("Init of the debugboard failed, all "
>> +                       "devices on the board are unusable.\n");
>
>  ' if (!mxc_expio_init'  should be used here as I mentioned previously.
>
> mxc_expio_init returns 0 if succesful.


Ops, sorry.  'if (mxc_expio_init'  check is correct.

So I think the only thing you need to address in v3 is the comment from Baruch.

Thanks,

Fabio Estevam



More information about the linux-arm-kernel mailing list