[PATCH 1/1] Mx35pdk: enable debug board support

Fabio Estevam festevam at gmail.com
Tue Oct 19 23:19:12 EDT 2010


On Tue, Oct 19, 2010 at 11:45 PM, xiao jiang <jgq516 at gmail.com> wrote:
> The patch is ok for me too,  and  the definition of EXPIO_PARENT_INT is
> similar like mx51_3ds board
> as I had said before.
> But since mxc_expio_init() should be return 0 if the debug board is
> detected, We should use
> mxc_expio_init(**_BASE_ADDR, EXPIO_PARENT_INT) other than
> !mxc_expio_init(**_BASE_ADDR, EXPIO_PARENT_INT), right?  The same issue also
> existed in mach-mx31_3ds.c.

mxc_expio_init returns 0 if the debug board is detected.
!mxc_expio_init returns 1 and print the error message.

So this is correct. I also get a message during the kernel boot saying
that the debug board was succesfully detected.

If you want, please resubmit a v2 of your original patch and also add my:
Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>


Fabio Esevam

More information about the linux-arm-kernel mailing list