[PATCH 1/2] hwmon: add generic GPIO fan driver

Guenter Roeck guenter.roeck at ericsson.com
Tue Oct 19 18:03:45 EDT 2010


Hi Simon,

one more comment ...

On Sun, 2010-10-17 at 11:50 -0400, Simon Guinot wrote:
[ ... ]
> +static int __devinit
> +fan_alarm_init(struct gpio_fan_data *fan_data, struct gpio_fan_alarm *alarm)
> +{

__devinit and __devexit can cause problems if this driver is built into
the kernel, but the underlying i2c master driver is built as module.

So please remove __devinit and __devexit.

Thanks,
Guenter





More information about the linux-arm-kernel mailing list