[PATCH 3/3] omap: add hwspinlock device
Ohad Ben-Cohen
ohad at wizery.com
Tue Oct 19 17:02:37 EDT 2010
On Tue, Oct 19, 2010 at 7:03 PM, Kevin Hilman
<khilman at deeprootsystems.com> wrote:
>> +postcore_initcall(hwspinlocks_init);
>
> Any reason this needs to be a postcore_initcall? Are there users of
> hwspinlocks this early in boot?
i2c-omap, which is subsys_initcall (the I2C bus is shared between the
A9 and the M3 on some OMAP4 boards).
And to allow early board code to reserve specific hwspinlock numbers
for predefined use-cases, we probably want to be before arch_initcall.
> The I2C Probaly subsys or even device_initcall
> is more appropriate here.
>
> I would've suspected that any users of hwspinlocks will be dependent on
> drivers for the other cores (e.g. syslink) which would likely be
> initialized much later.
>
> Kevin
>
More information about the linux-arm-kernel
mailing list