[PATCH 2/3] Add hardware timer support for Mindspeed Comcerto platflorm

[Stanley.Miao]

Hi, Russell,

Thanks for your review. I will update them and send V2.

Stanley.

2010/10/19 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> On Thu, Oct 14, 2010 at 04:38:08PM +0800, stanleymiao at gmail.com wrote:
<snip>
>> +     if (status & t->mask) {
>> +             /* we need to disable interrupt to simulate ONESHOT mode,
>> +              * do it before clearing the interrupt to avoid race */
>> +             if (dev->mode != CLOCK_EVT_MODE_PERIODIC)
>> +                     gptimer_disable(t);
>
> Err, the one-shot mode emulation support looks buggy and completely
> unnecessary.  Generally with clockevents, you tell it what the hardware
> supports and clockevents deals with it.  You shouldn't emulate modes
> that the hardware doesn't support - especially if you're going to ignore
> the 'cycles' from set_next_event().
>