[PATCHv2 1/1] omap: Ptr "isr_reg" tracked as NULL was dereferenced

Tony Lindgren tony at atomide.com
Mon Oct 18 19:11:47 EDT 2010

* Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov at nokia.com> [101014 23:11]:
> On Wed, 2010-10-13 at 16:09 +0400, Evgeny Kuznetsov wrote:
> > On Wed, 2010-10-13 at 17:20 +0530, ext Varadarajan, Charulatha wrote:
> Hi Tony,
> It is not a bug fix, it is just check to prevent potential issues. Used
> to warn in case of bug and prevent kernel oops. Check added only here
> (not all gpio code cleanup) since here it could cause kernel opps.
> Would you apply patch if I will leave only if condition section in
> patch?
> 	if (WARN_ON(!isr_reg))
> 		goto exit;
> If yes, I'll resend v3 patch.

Sounds like a valid check to me.


More information about the linux-arm-kernel mailing list