[PATCH 1/1] Mx35pdk: enable debug board support

[Fabio Estevam]

Hi Xiao,

2010/10/18 xiao jiang <jgq516 at gmail.com>:
> Hi Uwe & Fabio,
>
> 2010/10/15 <jgq516 at gmail.com>
>>
>> From: Xiao Jiang <jgq516 at gmail.com>
>>
>> Add debug board support, then kernel can boot from lan9217 ethernet.
>>
>> Signed-off-by: Xiao Jiang <jgq516 at gmail.com>
>> ---
>>  arch/arm/mach-mx3/mach-mx35_3ds.c          |    9 +++++++++
>>  arch/arm/plat-mxc/include/mach/iomux-mx3.h |    4 ++++
>>  2 files changed, 13 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx3/mach-mx35_3ds.c
>> b/arch/arm/mach-mx3/mach-mx35_3ds.c
>> index 1c30d72..78e0657 100644
>> --- a/arch/arm/mach-mx3/mach-mx35_3ds.c
>> +++ b/arch/arm/mach-mx3/mach-mx35_3ds.c
>> @@ -34,11 +34,16 @@
>>
>>  #include <mach/hardware.h>
>>  #include <mach/common.h>
>> +#include <mach/irqs.h>
>> +#include <mach/iomux-mx3.h>

You don't need to add this.

>>  #include <mach/iomux-mx35.h>
>> +#include <mach/3ds_debugboard.h>
>>
>>  #include "devices-imx35.h"
>>  #include "devices.h"
>>
>> +#define EXPIO_PARENT_INT       IOMUX_TO_IRQ(MX35_PIN_GPIO1_1)

Why don't you use MX35_PAD_GPIO1_1__GPIO1_1 instead which is already defined at:
arch/arm/plat-mxc/include/mach/iomux-mx35.h ?


Also, look at how MX31-3stack implemented the debug board support and
pass MXC_DEBUG_BOARD in the Kconfig.

>
> Any comments? And I can't the sdma driver in arch/arm/plat-mxc/ which is
> used by lots of i.mx chips, is somebody planing to do it or
> it will going to mainline soon ?

Sascha submitted initial support patches for i.MX SDMA.

Regards,

Fabio Estevam