[PATCH 1/7] arm/versatile: move pci code to plat-versatile

Linus Walleij linus.ml.walleij at gmail.com
Mon Oct 18 11:20:38 EDT 2010


2010/10/14 Arnd Bergmann <arnd at arndb.de>:

> The Xilinx PCI macro is used on both versatile-pb and
> realview-eb, so we should move the implementation to place
> where it can be shared.

>  arch/arm/Kconfig                     |    5 +
>  arch/arm/mach-versatile/Makefile     |    1 -
>  arch/arm/mach-versatile/pci.c        |  361 ----------------------------------
>  arch/arm/plat-versatile/Makefile     |    1 +
>  arch/arm/plat-versatile/xilinx-pci.c |  361 ++++++++++++++++++++++++++++++++++

What about arch/arm/common?

PCI drivers seem like they could be useful for others than ARM reference
designs too. Xilinx FPGAs are probably quite common anyway.

> (...)
> +obj-$(CONFIG_PCI_HOST_XILINX) += xilinx-pci.o
> diff --git a/arch/arm/plat-versatile/xilinx-pci.c b/arch/arm/plat-versatile/xilinx-pci.c
> new file mode 100644
> index 0000000..13c7e5f
> --- /dev/null
> +++ b/arch/arm/plat-versatile/xilinx-pci.c
> @@ -0,0 +1,361 @@
> +/*
> + *  linux/arch/arm/mach-versatile/pci.c

Hm this file path seems inappropriate why not just delete it.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list