[PATCH V2 2/2] ARM: S5PV310: Add support GPIOlib

[Jongsun Han]

Sangbeom Kim wrote:
> >
> > From: Jongpill Lee <boyko.lee at samsung.com>
> >
> > This patch adds GPIOlib support for S5PV310 and S5PC210.
> >
> > Signed-off-by: Jongpill Lee <boyko.lee at samsung.com>
> > Signed-off-by: Sangbeom Kim <sbkim73 at samsung.com>
> > ---
> > NOTE:
> > This patch used mapped VA IO as GPIO virtual address.
> > because firstly other Samsung SoC's GPIO used same method.
> > and I think that  it's better to keep the same method.
> > And ioremap also can be used for it.
> > But in the GPIO, there is no need to allocate VA area dynamically.
> > because GPIO can be used in any drivers anytime so it can't iounmap GPIO
> > VA area.
> >
> Ok...
> 
> (snip)
> 
> >  #define MAX_COMBINER_NR		40
> >
> > +#define S5P_IRQ_EINT_BASE	COMBINER_IRQ(MAX_COMBINER_NR, 0)
> > +
> > +#define S5P_EINT_BASE1		(S5P_IRQ_EINT_BASE + 0)
> > +#define S5P_EINT_BASE2		(S5P_IRQ_EINT_BASE + 16)
> > +
> 
> Hmm...
> If you want to add external interrupt, should be changed NR_IRQS too.
> 
> Will apply with fixing NR_IRQS.
> 

It seems that S5P_IRQ_EINT_BASE has wrong definition.
S5P_IRQ_EINT_BASE has to be COMBINER_IRQ(MAX_COMBINER_NR - 1, 0).

Thanks.

> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel