[PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped

[Kukjin Kim]

Mark Brown wrote:
> 
> On Wed, Oct 13, 2010 at 05:14:37PM +0900, Kukjin Kim wrote:
> > Mark Brown wrote:
> 
> > > Since it's exported we should make sure we're using the prototype
> > > others see.
> 
> > Hmm...I'm not sure that we need really this. Of course, it can be
helpful.
> > But if so, we have to apply this policy/rule to all of ours...but I
think we
> > don't need it now.
> 
> sparse warns about this issue so fixing issues like this is required to
> get a clean build for sparse users (I do pretty much all my builds with
> sparse).  I am sending fixes for everything I build, though obviously I
> don't have access to all Samsung systems, and it does make life easier
> when doing updates on the arch code.

You mean following?
arch/arm/mach-s3c64xx/setup-keypad.c:16:6: warning: symbol
'samsung_keypad_cfg_gpio' was not declared. Should it be static?

I didn't check sparse :-(
Ok...Ben seems to be busy now...so will apply in my tree.
And I will also fix it our Samsung stuff.

Ben, if any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.