[PATCH v2 4/6] ARM: S5P: Add EPLL rate change warning
kgene.kim at samsung.com
Wed Oct 13 04:21:48 EDT 2010
Mark Brown wrote:
> On Wed, Oct 13, 2010 at 04:55:55PM +0900, Kukjin Kim wrote:
> > Seungwhan Youn wrote:
> > > This patch adds warning about changing EPLL rate to notice that other
> > > driver that controls H/W, which is using EPLL, will has unknown
> > > by this EPLL rate change.
> > > + printk(KERN_WARNING "EPLL Rate changes from %lu to %lu\n",
> > > + clk->rate, rate);
> > Do we really need KERN_WARNING here?
> > How about just KERN_INFO?...In my opinion, to change EPLL value seems to
> > nearer 'information' message more than 'warning'.
> Personally I don't think it really makes much odds so long as the
> message is displayed on the console by default.
Hmm...yeah I mean just EPLL is used only in the audio and SPI now. However
we don't know which driver will use it later. And as you said, need to show
it. Ok...will apply.
Mr. Youn, no need to re-work this.
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
More information about the linux-arm-kernel