[PATCH 2/2] mx51: add resources for SD/MMC on i.MX51

[Eric Bénard]

Hi Uwe,

Le 12/10/2010 10:18, Uwe Kleine-König a écrit :
> On Tue, Oct 12, 2010 at 09:31:25AM +0200, Eric Bénard wrote:
>> the attached patch allows SD to work on i.MX51 with Wolfram's drivers
>> Tested on i.MX51.
>>
>> Based on original patch from: Richard Zhu<r65037 at freescale.com>
>> Signed-off-by: Eric Bénard<eric at eukrea.com>
>> ---
>>   arch/arm/mach-mx5/clock-mx51.c              |  102 ++++++++++++++++++++++++++-
>>   arch/arm/mach-mx5/devices-imx51.h           |    9 +++
>>   arch/arm/plat-mxc/include/mach/iomux-mx51.h |   45 ++++++++----
>>   3 files changed, 140 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx5/clock-mx51.c b/arch/arm/mach-mx5/clock-mx51.c
>> index 7deb683..9e8b268 100644
>> --- a/arch/arm/mach-mx5/clock-mx51.c
>> +++ b/arch/arm/mach-mx5/clock-mx51.c
>> @@ -41,6 +41,34 @@ static struct clk usboh3_clk;
>>
>>   #define MAX_DPLL_WAIT_TRIES	1000 /* 1000 * udelay(1) = 1ms */
>>
>> +static void __calc_pre_post_dividers(u32 div, u32 *pre, u32 *post)
>> +{
> I asked for a comment here.  E.g. valid ranges of pre and post and the
> task solved here (I assume it's "Find pre and post with pre * post =
> div"?).
>
will try to write something.
Richard : do you have a comment in mind for this function ?

 >> +		}
 >> +		*post = (div + *pre - 1) / *pre;
 > 		*post = DIV_ROUND_UP(div, *pre);
 >
 > I don't know if DIV_ROUND_UP is sensible, maybe use DIV_ROUND_CLOSEST?
 > I'd look into that when the comment above is in place.
 >
if you have an opinion before, this would be great to avoid a n+1 
version of this patch ;-)

>> -#define DEFINE_CLOCK1(name, i, er, es, pfx, p, s)	\
>> +#define DEFINE_CLOCK_CCGR(name, i, er, es, pfx, p, s)	\
> This is IMHO a good idea, but it should go in a seperate patch.  These
> clock changes are very sensible and so a working bisection is important
> here.
>
there is no clock change here only a define rename to avoid having 
DEFINE_CLOCK1, DEFINE_CLOCK2 ... is a separate patch really needed ?

Eric