[PATCH 3/3] mx51: Move OTG initialisation for all boards to a single file
amit.kucheria at linaro.org
Mon Oct 11 10:08:23 EDT 2010
On Mon, Oct 11, 2010 at 4:10 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
>> Do you think something like this will be better? It looks even more
>> scattered to me, the usb configuration information is scattered across
>> platform_data and phy_data.
> My problem is not that it's scattered around platform_data and phy_data,
> but that it's not possible to add proper i.MX51 support without
> introducing a initialize_otg_port which wont' be flexible enough for
> future boards.
>> Or did you want to get rid of platform_data->init too from the driver?
> No, I think we can't do this without breaking at least some boards. I
> found out that on some boards we have to configure the iomux pins and
> the rest of the USB hardware in a short time frame, otherwise we get
> ULPI errors.
So are the original patches(v2) to consolidate initialize_otg_port()
and introduce efikamx board support acceptable?
(I want to ensure I don't miss the next merge window, because Debian
wants to use these machines as their build machines)
More information about the linux-arm-kernel