[PATCH 3/3] staging: tidspbridge: remove memory consistency from TODO list

Arnd Bergmann arnd at arndb.de
Mon Oct 11 06:40:25 EDT 2010

On Sunday 10 October 2010, Felipe Contreras wrote:
> The mempool area is not handled by the kernel any more.

But tidspbridge still uses ioremap to set up the mapping for RAM,
even though it now is outside of the kernel linar mapping.

You should really only use ioremap on MMIO registers, nothing
else. These registers are marked as __iomem pointers and can only
be passed into functions that talk to the hardware like iowrite32
or writel, but not used like memory.

Please have a look at "sparse", which will warn about address space
violations among other things. The tidspbridge driver is full of them,
and you should fix the code that sparse warns about, which will
also show you all the places where ioremap is used incorrectly.


More information about the linux-arm-kernel mailing list