[PATCH] arch: arm/imx: fix memory init in imx_dma_request()

Vasiliy Kulikov segooon at gmail.com
Sun Oct 10 13:28:23 EDT 2010


imx_dma_request() didn't fill struct pointed by imxdma with zeroes
as it passed sizeof(pointer), not sizeof(struct) to memset().

Signed-off-by: Vasiliy Kulikov <segooon at gmail.com>
---
 I cannot compile this driver, so it is not tested.

 arch/arm/mach-imx/dma-v1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-imx/dma-v1.c b/arch/arm/mach-imx/dma-v1.c
index 3e8c47c..b5cc027 100644
--- a/arch/arm/mach-imx/dma-v1.c
+++ b/arch/arm/mach-imx/dma-v1.c
@@ -699,7 +699,7 @@ int imx_dma_request(int channel, const char *name)
 		local_irq_restore(flags);
 		return -EBUSY;
 	}
-	memset(imxdma, 0, sizeof(imxdma));
+	memset(imxdma, 0, sizeof(*imxdma));
 	imxdma->name = name;
 	local_irq_restore(flags); /* request_irq() can block */
 
-- 
1.7.0.4




More information about the linux-arm-kernel mailing list