missing definition of 's3c_gpio_getpull' function in 'plat-samsung'

Daein Moon moon9124 at samsung.com
Fri Oct 8 02:07:57 EDT 2010

Hi Ben Dooks and Kukjin,

I found an issue about s3c_gpio_getpull API.

The 'plat-samsung' provides 's3c_gpio_setpull' and 's3c_gpio_getpull'
to set and get pull-{none|up|down} of GPIO. But there is no
's3c_gpio_getpull' definition in 'arch/arm/plat-samsung/gpio-config.c',
and there is only declaration in the corresponding header file.

's3c_gpio_getpull' isn't supported/used. So if providing this api, its
definition should be inserted.

Otherwise, code that is used to provide s3c_gpio_getpull including
following code should be removed.

	extern s3c_gpio_pull_t s3c_gpio_getpull(unsigned int pin);

        .get_pull       = s3c_gpio_getpull_updown,

What do you think about that?

Best Regards,
Daein Moon

More information about the linux-arm-kernel mailing list