[PATCH] cpufreq for freescale mx51
amit.kucheria at linaro.org
Thu Oct 7 07:45:02 EDT 2010
On Thu, Oct 7, 2010 at 2:33 PM, Yong Shen <yong.shen at linaro.org> wrote:
>> > # Object file lists.
>> > -obj-y := cpu.o mm.o clock-mx51.o devices.o
>> > +obj-y := cpu.o mm.o clock-mx51.o devices.o cpu_wp-mx51.o
>> By hardcoding cpu_wp-mx51 here, you are making the assumption that even if
>> cpufreq is turned off, you'll still need the entire WP table to set the
>> cpu frequency. Why can't this be handled transparently in the clock code?
>> the clock code does the calculations, every board doesn't need to first
>> calls to get_cpu_wp.
> It has history. Not only cpufreq needs this table, other freescale drivers
> also need it, like dvfs and busfreq drivers. So it is better to be there. I
> do agree clock should do its calculation by itself.
> Agree about the rest.
Let's modify that history and do it the correct way then :)
When we come to the dvfs and bus drivers we'll fix them too.
More information about the linux-arm-kernel