[PATCH] serial: DCC(JTAG) serial and console emulation support
Daniel Walker
dwalker at codeaurora.org
Wed Oct 6 12:40:43 EDT 2010
On Wed, 2010-10-06 at 12:22 -0400, Nicolas Pitre wrote:
> On Wed, 6 Oct 2010, Daniel Walker wrote:
>
> > On Wed, 2010-10-06 at 11:47 -0400, Nicolas Pitre wrote:
> >
> > > It is the wrong fix nevertheless. And in this case it isn't a question
> > > of opinion.
> >
> > I'm not saying your wrong, I'm sure you know more about it than I do. I
> > was just letting you know why I added it .
>
> Sure. However it is best to _understand_ why such things may apparently
> fix things. In this case it would have been by accident, and the code
> could be broken again with a different gcc version.
>
> Adding "cc" in the clobber list is needed only when the asm code is
> modifying the condition flags.
>
> I'd suggest you look at the disassembly difference with and without it.
> My guess is that the whole thing gets optimized away as there is no
> dependencies to be dependent on, in which case the proper fix would be
> to mark it with "volatile".
Are you saying it's not needed for either the __dcc_putchar or
__dcc_getchar ?
With __dcc_getchar() Jeff O. (who is CC'd) discovered that the assembly
was setup in a way that assumed the condition bits were not touched, but
since they did get touched we ended up missing a branch in dcc_rx_chars
for checking if "tty" is set. Since we're branching in the assembly I'm
assuming we must be setting condition bits with the mrc instruction.
So for __dcc_getchar it seems like it for sure is need ..
For __dcc_putchar I add "cc" also because again we're branching, so I'm
assuming we're also setting condition bits.
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
More information about the linux-arm-kernel
mailing list