[PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish

[G, Manjunath Kondaiah]

> -----Original Message-----
> From: Peter Ujfalusi [mailto:peter.ujfalusi at nokia.com] 
> Sent: Monday, October 04, 2010 4:13 PM
> To: G, Manjunath Kondaiah
> Cc: Tony Lindgren; linux-omap at vger.kernel.org; Jarkko Nikula; 
> linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA 
> FIFO draining does not finish
> 
> On Monday 04 October 2010 12:17:41 ext G, Manjunath Kondaiah wrote:
> > 
> > ...
> > 
> > > +	/* OMAP3 Errata i541: sDMA FIFO draining does not finish */
> > 
> > This logic is required for multiple erratas.
> 
> As Tony requested, I have added a variable for flags to 
> handle the different erratas. I even added a macro to check 
> that the errata applies, so one can use:
> if (IS_DMA_ERRATA(DMA_ERRATA_XXXXX))
> 
> > Can we have seperate
> > function for handling this logic. More details at:
> > https://patchwork.kernel.org/patch/126271/
> 
> I see. That patch is for hwmod converted dma code, right?
> We need this fix without the hwmod to applied, and than 
> backport it to earlier kernel releases.
> 
> > As I mentioned in other mail, if you are introducing this 
> feature, it 
> > is better to convert existing erratas also to use this feature.
> 
> The upcoming hwmod conversion will take care of the cleanup.

If this is the case, not sure about intention of having dma_errata only
for these two erratas since all the erratas are not handled.

All the erratas will get cleaned up and errata handling feature
will be introduced along with dma hwmod changes.

If feel v3 version is better so that I can use these changes along 
dma hwmod.

It is upto Tony to decide.

> We _need_ these two small fixes ASAP, since it is fixing 
> serious problem in audio (and the same issue might bite other 
> areas as well).
> It is not the intention of this series to clean up the 
> arc/arm/plat-omap/dma.c.

Tony, 
How about having v3 series + review comments fixed(except comments
related errata handling). Errata handling will be done as part dma
hwmod. I am waiting for these patches so that I can rebase these
patches in DMA hwmod.

-Manjunath