[PATCH] support for SDMA memory to memory transfers

Linus Walleij linus.ml.walleij at gmail.com
Sat Oct 2 13:50:19 EDT 2010

2010/10/1 Wirtl, Tobias <Tobias.Wirtl at hbm.com>:

> This patch adds support for SDMA memory to memory transfers. It
> implements the prep_dma_memcpy function for the dmaengine. I'm sorry for
> the format.
> Any comments on this?

If you want comments on DMA engine code, send it to Dan Williams and
the LKML, see the MAINTAINERS file.

There is some weird linebreaks in my mail, looks like this is the
> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.4657

Please use git send-email with SMTP server and your patches will
probably look a lot nicer.

> *sdma_prep_dma_memcpy(
>        bd->ext_buffer_addr = dest;
>        bd->mode.count = len;
>        bd->mode.command = 0;
> -        bd->mode.status = BD_DONE | BD_EXTD | BD_CONT | BD_INTR;
> +        bd->mode.status = BD_DONE | BD_EXTD | BD_INTR | BD_WRAP;

What is this C99 comment doing here?

Certainly checkpatch does not agree with them so if you had run
it it would have complained. Apart from that the commented-out code
is also impossible to understand...

Linus Walleij

More information about the linux-arm-kernel mailing list