[PATCH] spi/pl022: make sure the chip_info dev pointer is set

Linus Walleij linus.walleij at stericsson.com
Fri Oct 1 06:37:57 EDT 2010


Grant Likely wrote:

>>        } else {
>> +               /* Users should not set this field */
>> +               chip_info->dev = &spi->dev;
>>                dev_dbg(&spi->dev,
>>                        "using user supplied controller_data settings\n");
>>        }
> 
> Nack.  data passed to a driver via the controller_data must be
> immutable as far as the device driver is concerned.

I posted another patch removing it instead, that's obviously the
right thing to do...

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list