[PATCH 5/6] ARM: Samsung: Add common samsung_gpiolib_to_irq function

Marek Szyprowski m.szyprowski at samsung.com
Fri Oct 1 01:19:16 EDT 2010


Hello,

On Friday, October 01, 2010 6:49 AM Kukjin Kim wrote:

...

> > diff --git a/arch/arm/plat-samsung/gpiolib.c
> b/arch/arm/plat-samsung/gpiolib.c
> > index c354089..f2dc389 100644
> > --- a/arch/arm/plat-samsung/gpiolib.c
> > +++ b/arch/arm/plat-samsung/gpiolib.c
> > @@ -197,3 +197,11 @@ void __init samsung_gpiolib_add_4bit2_chips(struct
> > s3c_gpio_chip *chip,
> >  		s3c_gpiolib_add(chip);
> >  	}
> >  }
> > +
> > +int samsung_gpiolib_to_irq(struct gpio_chip *chip, unsigned int offset)
> > +{
> > +	struct s3c_gpio_chip *s3c_chip = container_of(chip,
> > +			struct s3c_gpio_chip, chip);
> > +
> > +	return s3c_chip->irq_base + offset;
> > +}
> 
> Hi,
> 
> Following is for your information...
> 
> Moved samsung_gpiolib_to_irq() into plat-samsung/gpio.c because happened
> build error like following after applying this.
> 
> arch/arm/plat-s3c24xx/built-in.o:(.data+0x11c4): undefined reference to
> `samsung_gpiolib_to_irq'
> 
> The reason is that plat-samsung/gpiolib.c is not required for
> s3c24xx...applied anyway with modifying.

I must have missed that plat-samsung/gpiolib.c is not used for s3c-24xx. Thank
You for the fix!

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center





More information about the linux-arm-kernel mailing list