[PATCH v2] ARM: mx5: fix keypad clock name
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Tue Nov 30 14:20:05 EST 2010
Hello Fabio,
On Tue, Nov 30, 2010 at 05:13:36PM -0200, Fabio Estevam wrote:
> This fixes the following error during keypad driver probe:
>
> imx-keypad imx-keypad: failed to get keypad clock
> imx-keypad: probe of imx-keypad failed with error -2
>
> commit 3f88014 (ARM: imx: dynamically allocate imx-keypad devices)
> uses id=-1 for imx_kpp_device, so change the clock name accordingly.
This is true, but the reasoning is broken. 3f88014 uses -1, but only
with your patch that makes mx51 use the function introduced in 3f88014
this becomes a problem for mx51.
I suggest to squash this into your patch and adding a short notice to
the commit log why this is necessary.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list