[PATCH] make mc13783 code generic

[Uwe Kleine-König]

Hello,

On Tue, Nov 30, 2010 at 10:12:34AM +0100, Arnaud Patard wrote:
> > diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
> > index bff8157..4008bf6 100644
> > --- a/drivers/regulator/Makefile
> > +++ b/drivers/regulator/Makefile
> > @@ -29,7 +29,7 @@ obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o
> >  obj-$(CONFIG_REGULATOR_DA903X)	+= da903x.o
> >  obj-$(CONFIG_REGULATOR_PCF50633) += pcf50633-regulator.o
> >  obj-$(CONFIG_REGULATOR_PCAP) += pcap-regulator.o
> > -obj-$(CONFIG_REGULATOR_MC13783) += mc13783-regulator.o
> > +obj-$(CONFIG_REGULATOR_MC13783) += mc13783-regulator.o mc13xxx-regulator-core.o
> >  obj-$(CONFIG_REGULATOR_AB3100) += ab3100.o
> 
> Why don't you add a common Kconfig entry ? I've the (wrong ?) feeling
> that you're going to do :
> obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o mc13xxx-regulator-core.o
> 
> which should be avoided. Being able to build mc13783 and mc13892 support
> at the same time is a must-have imho.
AFAIK using this idiom is just fine.  You could argue that it's cleaner
to have a CONFIG_REGULATOR_MC13XXX, but the result should be identical.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |