[PATCH 28/51] ARM: mx25: dynamically allocate mxc-ehci devices

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Nov 29 02:52:35 EST 2010


Hello Jaume,

On Mon, Nov 29, 2010 at 08:34:43AM +0100, jaume at fqingenieria.es wrote:
> >> On 17/11/2010 22:29, Uwe Kleine-König wrote:
> >>> According to the reference manual of the i.MX25 the host controller
> >>> uses an
> >>> offset of 0x200 not 0x400 as was specified in the resources for
> >>> mxc_usbh2.
> >>>
> >>> Needs-Testing: yes
> > Actually I wanted that tag to make me stop sending this patch out.
> > Well, not too bad IMHO.
> 
> Did you mean a way of testing/marking the patches? Please clarify.
I intended to test this change before sending it out.  That's why I
wrote "Needs-Testing: yes" into the commit log.  I somehow thought I'd
see that before sending the patch out.  The upside of my failure here is
that we now know the definitive offset and hopefully in the next
revision of the documentation the value is fixes.  So the world became a
bit better :-)

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list