[PATCH] ARM: Gemini: Add support for PCI Bus
Hans Ulli Kroll
ulli.kroll at googlemail.com
Sat Nov 27 07:16:24 EST 2010
On Fri, 26 Nov 2010, Michał Mirosław wrote:
> 2010/11/20 Hans Ulli Kroll <ulli.kroll at googlemail.com>:
> > Add support for PCI Bus on Gemini Devices SL3516
> >
> > Signed-off-by: Hans Ulli Kroll <ulli.kroll at googlemail.com>
> > ---
> [...]
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index a19a526..5d4b398 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -307,6 +307,7 @@ config ARCH_GEMINI
> > select CPU_FA526
> > select ARCH_REQUIRE_GPIOLIB
> > select ARCH_USES_GETTIMEOFFSET
> > + select PCI
> > help
> > Support for the Cortina Systems Gemini family SoCs
> >
> [...]
>
> I think it's better to add ARCH_GEMINI to CONFIG_PCI dependencies.
> AFAIK IB-4220B NAS does not use PCI and doesn't need all that code.
> Board support entries could select PCI if the board is useless without
> it.
>
I know this, I have some.
There are many boards with PCI i.e WBD 222.
Other ARM devices uses the same select inside ARCH_*
I don't want to pollute drivers/pci/Kconfig.
Ulli
More information about the linux-arm-kernel
mailing list