[PATCH v2 2/3] ARM: cns3xxx: Add architecture definition for EHCI/OHCI controller
cbouatmailru at gmail.com
Thu Nov 25 11:15:50 EST 2010
On Thu, Nov 25, 2010 at 10:37:16AM -0500, Alan Stern wrote:
> > > 2010/11/25 Anton Vorontsov <cbouatmailru at gmail.com>:
> > > > On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote:
> > > > [...]
> > > >> > Â #include <linux/module.h>
> > > >> > Â #include <linux/io.h>
> > > >> > Â #include <linux/delay.h>
> > > >> > +#include <asm/atomic.h>
> > > >> It's not necessary for mach/pm.h already included it, right?
> > > >
> > > > Technically, it's not necessary. But in Linux we don't rely on
> > > > headers including other headers.
> Just saw this. Don't be ridiculous -- this happens all over the place.
> People generally aren't aware of it, because it's next to impossible to
> verify that all the headers needed by a source file are included
Sure. But that doesn't mean we shouldn't try to keep these things
I just noticed that the patch introduced atomic_t usage, but didn't
include asm/atomic.h, so I corrected this before applying that patch.
So I don't see what's the fuss is about. :-)
Email: cbouatmailru at gmail.com
More information about the linux-arm-kernel