[patch 1/1] iMX51: introduce MX51_GPIO_NR
linuxzsc at gmail.com
Wed Nov 24 18:06:47 EST 2010
On Thu, Nov 25, 2010 at 1:04 AM, Arnaud Patard
<arnaud.patard at rtp-net.org> wrote:
> Fabio Estevam <festevam at gmail.com> writes:
>> Hi Arnaud,
>> 2010/11/22 Arnaud Patard <arnaud.patard at rtp-net.org>:
>>> Currently, to define a GPIO number, we're using something like :
>>> #define EFIKAMX_PCBID0 (2*32 + 16)
>>> to define GPIO 3 16.
>>> This is not really readable and it's error prone imho (note the 3 vs 2).
>>> So, I'm introducing a new macro to define this in a better way. Now, the
>>> code sample become :
>>> #define EFIKAMX_PCBID0 MX51_GPIO_NR(3, 16)
>> Can you rename the macro to MX5x_GPIO_NR instead of MX51_GPIO_NR?
>> This way we can also use this macro for MX53 and MX508 when they show
>> up in mainline.
> I've been wondering about to use MX5X instead of MX51 but I kept MX51
> because I didn't know how the GPIO will work on MX53. If they're
> compatible, you're right, the name should be MX5X_GPIO_NR and not
> MX51_GPIO_NR. Assuming you mail means that, I'm going to switch to
For MX5x at lease for now (MX51/53/508), One bank is 32 gpios. But
bank number is different.
More information about the linux-arm-kernel