[PATCH v2] ARM: perf: split up perf_event.c by architecture

Jean Pihet jean.pihet at newoldbits.com
Tue Nov 23 10:05:18 EST 2010


Will,

On Tue, Nov 23, 2010 at 3:38 PM, Will Deacon <will.deacon at arm.com> wrote:
> Hi Jean,
>
>> About the patch 5/5:
>>
>> This probably is nitpicking from my side, but there still are warnings
>> generated by checkpatch:
>>
>> WARNING: please, no space before tabs
>> #3999: FILE: arch/arm/kernel/perf_event_xscale.c:9:
>> + * ^I- xscale1pmu: 2 event counters and a cycle counter$
>>
>> WARNING: please, no space before tabs
>> #4000: FILE: arch/arm/kernel/perf_event_xscale.c:10:
>> + * ^I- xscale2pmu: 4 event counters and a cycle counter$
>>
>> total: 0 errors, 2 warnings, 4754 lines checked
>
> These are in comments though so I'm not sure the coding-style rules
> apply. I can change it if if *really* annoys you though :)
Not at all! checkpatch is useful but can be annoying at times.

>
>> Other than that, nice work!
>>
>> Acked-by: Jean Pihet <j-pihet at ti.com>
>
> Great, thanks! The hard part is going to be getting this merged
> without breaking any pending patches to perf_event.c. I think we're
> alright at the moment for 2.6.38 but if you see any patches getting
> scheduled that touch the old code, please let me know.
Ok will do!

Thanks,
Jean

>
> Will
>
>
>
>



More information about the linux-arm-kernel mailing list