[PATCH v2 8/9] ARM: Thumb-2: Fix long-distance conditional branches in head.S for Thumb-2.

[Nicolas Pitre]

On Mon, 22 Nov 2010, Russell King - ARM Linux wrote:

> On Mon, Nov 22, 2010 at 03:24:11PM -0500, Nicolas Pitre wrote:
> > On Mon, 22 Nov 2010, Russell King - ARM Linux wrote:
> > > No, you're not thinking right.  It was _intentional_ that __error_p
> > > ended up in a different section to __init.  With CPU hotplug, as it
> > > is called from the hotplug CPU initialization path, it needs to be
> > > available for that path to call.
> > 
> > Well... agreed for the hotplug CPU case.  The section selection is good 
> > as it is for that.
> > 
> > However I doubt this was intentional when commit 75d90832d5 was created, 
> > which is when the actual section move took place.
> 
> Well, T2 is not something I particularly test for.  There's already too
> many combinations to test as it is.

Fair enough.  My point was only about the unintentional drop of the 
__init section attribute for the __error_p and __error_a functions (and 
probably some others in head-common.S) from commit 75d9083 which is 
orthogonal to the T2 issue.  It looks that this bug has turned itself 
into a feature that the CPU hotplug support depends on, although I'd 
probably prefer if there was a __hotplug_init section that would still 
be discarded after boot when CPU hotplug support is not configured in.


Nicolas