[PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

Kanigeri, Hari h-kanigeri2 at ti.com
Mon Nov 22 06:58:04 EST 2010


Felipe,

On Mon, Nov 22, 2010 at 5:51 AM, Felipe Balbi <balbi at ti.com> wrote:
> Hi,
>
> On Mon, Nov 22, 2010 at 05:46:53AM -0600, Kanigeri, Hari wrote:
>>>
>>> From the dmtimer stuff, it looks like the driver defines the version
>>
>> types, which hwmod uses to define the rev field.
>>
>> /* timer ip constants */
>> #define OMAP_TIMER_IP_LEGACY                    0x1
>> #define OMAP_TIMER_IP_VERSION_2                 0x2
>
> in that case, it's the same as if you pass in a flag via platform_data.
> You might as well call it rev, then the diff when converting to hwmod
> will be smaller maybe :-p

I agree with you, the changes should be minimal converting to hwmod.


Thank you,
Best regards,
Hari Kanigeri



More information about the linux-arm-kernel mailing list