[PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map_xfer'

Sergei Shtylyov sshtylyov at mvista.com
Sat Nov 20 06:54:31 EST 2010


Hello.

On 20-11-2010 13:08, Jean-Christophe PLAGNIOL-VILLARD wrote:

> passing argument 2 of 'dma_map_single' discards qualifiers from pointer target type

> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD<plagnioj at jcrosoft.com>
> ---
>   drivers/spi/atmel_spi.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)

> diff --git a/drivers/spi/atmel_spi.c b/drivers/spi/atmel_spi.c
> index 154529a..2cf6abd 100644
> --- a/drivers/spi/atmel_spi.c
> +++ b/drivers/spi/atmel_spi.c
> @@ -352,8 +352,10 @@ atmel_spi_dma_map_xfer(struct atmel_spi *as, struct spi_transfer *xfer)
>
>   	xfer->tx_dma = xfer->rx_dma = INVALID_DMA_ADDRESS;
>   	if (xfer->tx_buf) {
> +		void *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */
> +

    Aren't casts to 'void *' automatic?

>   		xfer->tx_dma = dma_map_single(dev,
> -				(void *) xfer->tx_buf, xfer->len,
> +				nonconst_tx, xfer->len,
>   				DMA_TO_DEVICE);
>   		if (dma_mapping_error(dev, xfer->tx_dma))
>   			return -ENOMEM;

WBR, Sergei



More information about the linux-arm-kernel mailing list