[PATCH] ARM: imx: Return the correct chip version instead of zero for mx51 and mx53

Dinh.Nguyen at freescale.com Dinh.Nguyen at freescale.com
Thu Nov 18 18:51:41 EST 2010


From: Dinh Nguyen <Dinh.Nguyen at freescale.com>

get_mx51_srev() and get_mx53_srev() are returning zero so cpu_silicon_rev
becomes zero instead of the correct chip version.

Signed-off-by: Dinh Nguyen <Dinh.Nguyen at freescale.com>
---
 arch/arm/mach-mx5/cpu.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-mx5/cpu.c b/arch/arm/mach-mx5/cpu.c
index 974a22f..0949251 100644
--- a/arch/arm/mach-mx5/cpu.c
+++ b/arch/arm/mach-mx5/cpu.c
@@ -22,22 +22,20 @@ static int cpu_silicon_rev = -1;
 
 #define SREV 0x24
 
-static int get_mx51_srev(u32 rev)
+static void get_mx51_srev(u32 rev)
 {
 	if (rev == 0x0)
 		cpu_silicon_rev = IMX_CHIP_REVISION_2_0;
 	else if (rev == 0x10)
 		cpu_silicon_rev = IMX_CHIP_REVISION_3_0;
-	return 0;
 }
 
-static int get_mx53_srev(u32 rev)
+static void get_mx53_srev(u32 rev)
 {
 	if (rev == 0x0)
 		cpu_silicon_rev = IMX_CHIP_REVISION_1_0;
 	else if (rev == 0x10)
 		cpu_silicon_rev = IMX_CHIP_REVISION_2_0;
-	return 0;
 }
 
 static void query_silicon_parameter(void)
@@ -54,9 +52,9 @@ static void query_silicon_parameter(void)
 
 	cpu_silicon_rev = 0;
 	if (cpu_is_mx51())
-		cpu_silicon_rev = get_mx51_srev(rev);
+		get_mx51_srev(rev);
 	else if(cpu_is_mx53())
-		cpu_silicon_rev = get_mx53_srev(rev);
+		get_mx53_srev(rev);
 }
 
 /*
-- 
1.6.0.4





More information about the linux-arm-kernel mailing list