[PATCH 2/5] ARM: perf: avoid exposing internal stop function for v6 PMU

Will Deacon will.deacon at arm.com
Tue Nov 16 04:57:05 EST 2010


Hi Jamie,

> On Mon, Nov 15, 2010 at 05:31:00PM +0000, Will Deacon wrote:
> > Unlike other pmu functions, armv6pmu_pmu_stop is not declared static.
> > This patch adds the missing keyword.
> >
> > Cc: Jamie Iles <jamie.iles at picochip.com>
> > Signed-off-by: Will Deacon <will.deacon at arm.com>
> > ---
> Yep, good spot. Btw, my employer has changed to Exchange for our email and it
> has a habit of munging patches on the way in so I'll have to switch to my
> personal email now!

Urgh! We have to use Exchange too and it makes a total mess of patches.
You can run dos2unix and write a script to fix wrapped lines but you get
into trouble when there is trailing whitespace in a file and diff uses
that line for context. Then I usually resort to hexdump, which takes far
too long to be practical for larger patches.

> Acked-by: Jamie Iles <jamie at jamieiles.com>

Thanks. I'll use this email address in future.

Will





More information about the linux-arm-kernel mailing list