suspicious code in linux/arch/arm/common/sa1111.c

Eric Miao eric.y.miao at gmail.com
Tue Nov 16 04:09:59 EST 2010


On Tue, Nov 16, 2010 at 5:07 PM, Pavel Machek <pma at sysgo.com> wrote:
> Hi!
>
> Is this good idea?
>
> Signed-off-by: Pavel Machek <pma at sysgo.com>

Yep, obviously was a typo.

>
> diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
> --- linux.ofic//arch/arm/common/sa1111.c        2010-10-17 20:31:13.000000000 +0200
> +++ linux/arch/arm/common/sa1111.c      2010-11-05 10:44:17.000000000 +0100
> @@ -282,7 +312,7 @@
>        for (i = 0; i < 8; i++) {
>                sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
>                sa1111_writel(ip0, mapbase + SA1111_INTPOL0);
> -               if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
> +               if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
>                        break;
>        }
>
>



More information about the linux-arm-kernel mailing list