[PATCH v8 4/9] davinci: McASP configuration for Omapl138-Hawkboard

Nori, Sekhar nsekhar at ti.com
Mon Nov 15 06:10:36 EST 2010


Hi Victor,

On Sat, Nov 13, 2010 at 04:08:50, vm.rod25 at gmail.com wrote:
> From: Victor Rodriguez <victor.rodriguez at sasken.com>
>
> This patch defines Pin Mux configuration for MacASP
> used on the Hawkboard-L138 system in order to add Audio support
>
> Signed-off-by: Victor Rodriguez <victor.rodriguez at sasken.com>
> Tested-by: Rene Gonzalez <renegs.2378 at gmail.com>
> ---
>  arch/arm/mach-davinci/da850.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> index 63916b9..f033a0a 100644
> --- a/arch/arm/mach-davinci/da850.c
> +++ b/arch/arm/mach-davinci/da850.c
> @@ -591,7 +591,7 @@ const short da850_cpgmac_pins[] __initdata = {
>  const short da850_mcasp_pins[] __initdata = {
>       DA850_AHCLKX, DA850_ACLKX, DA850_AFSX,
>       DA850_AHCLKR, DA850_ACLKR, DA850_AFSR, DA850_AMUTE,
> -     DA850_AXR_11, DA850_AXR_12,
> +     DA850_AXR_11, DA850_AXR_12, DA850_AXR_13, DA850_AXR_14,

Looks like I missed pointing this out previously, but extending
this list to take care of all boards will not be right since
(for example) AXR13 and AXR14 pins could be used for different
purpose on different boards.

The right way would be to make this a per-board list. Since it
is marked __initdata, that wouldn't lead to bloat.

Thanks,
Sekhar




More information about the linux-arm-kernel mailing list