[PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

[Taneja, Archit]

Hi,

Bryan Wu wrote:
> On Mon, Nov 15, 2010 at 12:05 PM, Taneja, Archit
> <archit at ti.com> wrote:
>> Hi,
>> 
>> bryan.wu at canonical.com wrote:
>>> On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen
>> 
>> [snip]
>> 
>>>> 
>>>> For both panel power on and off some panels require some sleep times:
>>>> when powering on, the video interface has to be enabled for some
>>>> time before the panel can be enabled, and similarly when powering
>>>> off the video interface needs to be on for some time after the panel has
>>>> been disabled. 
>>>> 
>>> 
>>> Actually, in my previous version patches, I introduced
>>> .power_on_delay and .power_off_delay in panel_configs, which contains
>>> the sleep value for msleep(). But Archit told me this is not
>>> necessary, so I removed that.
>> 
>> I had asked you to remove it from omap_dss_device to a more specific
>> struct for the generic dpi driver :)
>> 
> 
> Yeah, no problem.
> 
>> It should be in the 'panel_generic_dpi_data' struct now.
>> 
> 
> I think the delay value is related to panel, which can be
> found in sharp_ls and sharp_lq drivers. So it might be in the "panel_configs"
> struct?

Yes, I think that makes more sense.

Thanks,
Archit