[PATCH] ARM: Common GIC entry macro code V2

Magnus Damm magnus.damm at gmail.com
Thu Nov 11 22:26:24 EST 2010


On Thu, Nov 11, 2010 at 6:51 PM, Kyungmin Park <kmpark at infradead.org> wrote:
> On Thu, Nov 11, 2010 at 6:36 PM, Kukjin Kim <kgene.kim at samsung.com> wrote:
>> Kyungmin Park wrote:
>>>
>>> Can you include the "arch/arm/mach-s5pv310/include/mach/entry-macro.S"
>> also?
>>>
>> In conclusion, can't it now.
>> Because according to current interrupt number structure of Samsung SoCs,
>> irqnr macro need to add S5P_IRQ_OFFSET, 32.
>>
>> Or have to add #ifdef in there...But don't like it.
>
> I wonder why Samsung goes another way, use the common codes. if
> required, modify to use the common codes.

Yes, it would be nice if Samsung could use the common code as well. I
will however ignore this for now to focus on getting something merged
that most people can use. The Samsung bits can be dealt with
incrementally.

Thanks,

/ magnus



More information about the linux-arm-kernel mailing list