[PATCH v3] msm: smd: Reduce driver log chatter
Joe Perches
joe at perches.com
Wed Nov 10 13:24:17 EST 2010
On Wed, 2010-11-10 at 09:59 -0800, David Brown wrote:
> arch/arm/mach-msm/smd.c | 18 ++++++++++--------
Hi again David. More trivia. Ignore at your pleasure.
> 1 files changed, 10 insertions(+), 8 deletions(-)
> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
A moderately common kernel style uses macros like:
#define FUNC_ENTER() pr_debug("--> %s\n", __func__);
#define FUNC_EXIT() pr_debug("<-- %s\n", __func__);
or
#define FUNC_ENTER() pr_debug("Enter %s\n", __func__);
#define FUNC_EXIT() pr_debug("Exit %s\n", __func__);
The macro names vary.
I've seen enter, _enter, kenter, func_enter, etc.
> @@ -939,7 +941,7 @@ int smsm_set_sleep_duration(uint32_t delay)
> int smd_core_init(void)
> {
> int r;
> - pr_info("smd_core_init()\n");
> + pr_debug("smd_core_init()\n");
FUNC_ENTER();
> @@ -992,14 +994,14 @@ int smd_core_init(void)
> smsm_change_state(SMSM_STATE_APPS_DEM, ~0, 0);
> #endif
>
> - pr_info("smd_core_init() done\n");
> + pr_debug("smd_core_init() done\n");
FUNC_EXIT();
> static int __devinit msm_smd_probe(struct platform_device *pdev)
> {
> - pr_info("smd_init()\n");
> + pr_debug("smd_init()\n");
wrong function name? FUNC_ENTER();
More information about the linux-arm-kernel
mailing list