[PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset

Kevin Hilman khilman at deeprootsystems.com
Tue Nov 9 12:31:41 EST 2010


"G, Manjunath Kondaiah" <manjugk at ti.com> writes:

> The commit '311225e6' is missing '.module_offs' in prcm
> structure in omap3 hwmod data base which results in accessing
> wrong register for I2Cx IDLEST bit monitoring.
>
> Added module offsets for accessing register CM_IDLEST1_CORE.
>
> Patch tested on Zoom3 using omap2plus_defconfig

Thanks, will fold this into original series.

Kevin

> Signed-off-by: G, Manjunath Kondaiah <manjugk at ti.com>
> Signed-off-by: Charulatha V <charu at ti.com>
> Cc: Kevin Hilman <khilman at deeprootsystems.com>
> Cc: Paul Walmsley <paul at pwsan.com>
> Cc: Rajendra Nayak <rnayak at ti.com>
> Cc: Benoit Cousson <b-cousson at ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index d0d8030..22831e9 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
>  	.main_clk	= "i2c1_fck",
>  	.prcm		= {
>  		.omap2 = {
> +			.module_offs = CORE_MOD,
>  			.prcm_reg_id = 1,
>  			.module_bit = OMAP3430_EN_I2C1_SHIFT,
>  			.idlest_reg_id = 1,
> @@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
>  	.main_clk	= "i2c2_fck",
>  	.prcm		= {
>  		.omap2 = {
> +			.module_offs = CORE_MOD,
>  			.prcm_reg_id = 1,
>  			.module_bit = OMAP3430_EN_I2C2_SHIFT,
>  			.idlest_reg_id = 1,
> @@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
>  	.main_clk	= "i2c3_fck",
>  	.prcm		= {
>  		.omap2 = {
> +			.module_offs = CORE_MOD,
>  			.prcm_reg_id = 1,
>  			.module_bit = OMAP3430_EN_I2C3_SHIFT,
>  			.idlest_reg_id = 1,



More information about the linux-arm-kernel mailing list