[PATCH v2] ARM: s3c2442: Setup gpio {set,get}_pull callbacks

Vasily Khoruzhick anarsoul at gmail.com
Mon Nov 8 04:08:11 EST 2010


On Saturday 06 November 2010 18:09:37 Abdoulaye Walsimou GAYE wrote:

Restored CC list, please don't clean it next time.

> > -	.set_pull	= s3c_gpio_setpull_1up,
> > -	.get_pull	= s3c_gpio_getpull_1up,
> > 
> >   };
> 
> This part of your patch will prevent s3c2440 based boards to boot see [1]

Well, your patch breaks compilation for s3c2442 at all (see comment from my 
patch)

Ben, why machine-specific init is called before cpu init?

Regards
Vasily



More information about the linux-arm-kernel mailing list