[PATCH 4/6] omap: iommu: intial hwmod support

Ramirez Luna, Omar omar.ramirez at ti.com
Sun Nov 7 11:21:54 EST 2010


On Sat, Nov 6, 2010 at 4:05 PM, Cousson, Benoit <b-cousson at ti.com> wrote:
>>  static struct iommu_device omap3_devices[] = {
>
> You should not need that at all, you are just duplicating the data that are
> already in hwmod, and then you are going to create real platform_device.

ok, will try that.

>>        for (i = 0; i<  num_iommu_devices; i++) {
>
> Don't do that, just iterate over the hwmod class using
> omap_hwmod_for_each_by_class. Please have a look at the drivers with
> multiple devices that are already using hwmod (i2c, uart...).

And this too.

Regards,

Omar



More information about the linux-arm-kernel mailing list