[patch v3 01/10] efikamx: read board id

[Arnaud Patard (Rtp)]

Nguyen Dinh-R00091 <R00091 at freescale.com> writes:

Hi,

> Hi,
>
>>-----Original Message-----
>>From: linux-arm-kernel-bounces at lists.infradead.org
> [mailto:linux-arm-kernel-
>>bounces at lists.infradead.org] On Behalf Of Arnaud Patard
>>Sent: Tuesday, October 26, 2010 3:07 PM
>>To: linux-arm-kernel at lists.infradead.org
>>Cc: matt at genesi-usa.com; Sascha Hauer; Arnaud Patard; Amit Kucheria
>>Subject: [patch v3 01/10] efikamx: read board id
>>
>>read board id value from the GPIO3_16/17/11
>>
>>Signed-off-by: Arnaud Patard <arnaud.patard at rtp-net.org>
>>Index: linux-2.6-submit/arch/arm/mach-mx5/board-mx51_efikamx.c
>>===================================================================
>>--- linux-2.6-submit.orig/arch/arm/mach-mx5/board-mx51_efikamx.c
> 2010-10-21 08:29:23.000000000 +0200
>>+++ linux-2.6-submit/arch/arm/mach-mx5/board-mx51_efikamx.c
> 2010-10-21 08:29:46.000000000 +0200
>>@@ -39,12 +39,26 @@
>>
>> #define	MX51_USB_PLL_DIV_24_MHZ	0x01
>>
>>+#define EFIKAMX_PCBID0		(2*32 + 16)
>>+#define EFIKAMX_PCBID1		(2*32 + 17)
>>+#define EFIKAMX_PCBID2		(2*32 + 11)
>>+
>>+/* the pci ids pin have pull up. they're driven low according to board
> id */
>>+#define MX51_PAD_PCBID0	IOMUX_PAD(0x518, 0x130, 3, 0x0,   0,
> PAD_CTL_PUS_100K_UP)
>>+#define MX51_PAD_PCBID1	IOMUX_PAD(0x51C, 0x134, 3, 0x0,   0,
> PAD_CTL_PUS_100K_UP)
>>+#define MX51_PAD_PCBID2	IOMUX_PAD(0x504, 0x128, 3, 0x0,   0,
> PAD_CTL_PUS_100K_UP)
>>+
>
> Seems a bit wasteful to redefine the IOMUX definitions. Couldn't you
> just do something like this?

With a define, you have only 1 place to look at when debugging and
configuring the pad requires only to put it in the list like any other
pad. With your approach, we need to change the pad control and then call
mxc_iomux_v3_setup_multiple_pads() separately. It's making extra-step in
the process.
Also, such a specific treatment for configuring theses GPIOs means for
me more errors/bugs possible.

Arnaud